Remove full provider's specification from TEST_TYPES #24901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new provider's selective tests introduce option to specify which providers should be tested (which is automatically used in CI). This works fine but in case when we remove Provider's tests from the list (MySQL/MsSQL) the removal was done only for the Provider's part, not for the detailed list of providers. That led to test attempting to run ``` [amazon,apache.hive,google,mysql,postgres] ``` for example. This PR fixes it by removing full Provider's specification.
josh-fell
approved these changes
Jul 7, 2022
potiuk
added a commit
that referenced
this pull request
Jul 21, 2022
The new provider's selective tests introduce option to specify which providers should be tested (which is automatically used in CI). This works fine but in case when we remove Provider's tests from the list (MySQL/MsSQL) the removal was done only for the Provider's part, not for the detailed list of providers. That led to test attempting to run ``` [amazon,apache.hive,google,mysql,postgres] ``` for example. This PR fixes it by removing full Provider's specification. (cherry picked from commit 1404d67)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new provider's selective tests introduce option to specify
which providers should be tested (which is automatically
used in CI). This works fine but in case when we remove
Provider's tests from the list (MySQL/MsSQL) the removal was
done only for the Provider's part, not for the detailed list
of providers. That led to test attempting to run
for example.
This PR fixes it by removing full Provider's specification.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.